[algorithm] Check whether the needle tip is inside the detected tetrahedron proximity before adding it#64
Merged
Merged
Conversation
epernod
requested changes
Aug 13, 2025
…etected tetrahedron to the insertionOutput
th-skam
force-pushed
the
fix-outsideProx
branch
from
512a07c to
7e6dc02
Compare
Collaborator
Author
|
I added the comments @epernod |
epernod
reviewed
Aug 13, 2025
epernod
left a comment
epernod
left a comment
Contributor
There was a problem hiding this comment.
something went wrong with the ci
th-skam
force-pushed
the
fix-outsideProx
branch
from
e963681 to
97ad9dc
Compare
Contributor
|
be careful that if you always force push, it is hard to follow the changes as all the history is wiped out. It is like ready again a new PR. |
epernod
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, proximities are no longer used for the needle-volume coupling once the needle has exited from the other side of the volume. See video:
25-08-11-InsertionExitFix.mp4
Issues
Fixes #63